Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http2_keepalive panics on the client side #1730

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Fix http2_keepalive panics on the client side #1730

merged 2 commits into from
Jun 15, 2024

Conversation

AmeliasCode
Copy link
Contributor

Motivation

#1726 fixed http2_keepalive on the server side, but panics were still present when using http2_keepalive on the client side.

Solution

Add the necessary timer to the SharedExec when constructing it via tonic::transport::service::Connection.

@akiradeveloper
Copy link

@AmeliasCode My test now works using the code on your repository. Thank you.

$ cargo run 1
   Compiling tonic-build v0.11.0 (https://github.com/AmeliasCode/tonic#91a189d6)
   Compiling tonic v0.11.0 (https://github.com/AmeliasCode/tonic#91a189d6)
   Compiling tonic-hyper10-debug v0.1.0 (/Users/akira/Source/tonic-hyper10-debug)

@djc djc added this pull request to the merge queue Jun 15, 2024
@djc
Copy link
Contributor

djc commented Jun 15, 2024

Great, thanks!

Merged via the queue into hyperium:master with commit 8fe97de Jun 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmeliasCode @akiradeveloper @djc